-
Notifications
You must be signed in to change notification settings - Fork 110
BE-268: HashQL: Rename PreInlining to PreInline for consistency #8238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BE-268: HashQL: Rename PreInlining to PreInline for consistency #8238
Conversation
PR SummaryAligns naming of the MIR pre-inlining pass across the codebase.
Written by Cursor Bugbot for commit 447336b. This will update automatically on new commits. Configure here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8238 +/- ##
=======================================
Coverage 59.72% 59.73%
=======================================
Files 1214 1214
Lines 115245 115275 +30
Branches 5062 5063 +1
=======================================
+ Hits 68832 68861 +29
- Misses 45611 45612 +1
Partials 802 802
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🤖 Augment PR SummarySummary: Renames the MIR pre-inlining transform pass to Changes:
🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CodSpeed Performance ReportMerging this PR will not alter performanceComparing Summary
|
570512b to
1120ba1
Compare
1046b08 to
01aa550
Compare
01aa550 to
8002918
Compare
1120ba1 to
17bacd7
Compare
8002918 to
f0ef5be
Compare
17bacd7 to
4df23e6
Compare
4df23e6 to
3e63d95
Compare
f0ef5be to
843c87a
Compare
3e63d95 to
447336b
Compare

🌟 What is the purpose of this PR?
Rename the
PreInliningpass toPreInlinefor consistency with other transform passes in the codebase. This includes renaming the associated files, module references, and test directories.🔍 What does this change?
PreInliningclass toPreInlinein the MIR transform passespre_inlining.rsfile topre_inline.rspre_inliningdirectory topre_inlinemir_pass_transform_pre_inliningtomir_pass_transform_pre_inlinePre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
Existing tests were moved to the new directory structure and continue to cover the functionality.
❓ How to test this?