-
Notifications
You must be signed in to change notification settings - Fork 110
BE-270: HashQL: Optimize empty tuples to unit constants in MIR #8237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: bm/be-197-hashql-implement-inlining
Are you sure you want to change the base?
BE-270: HashQL: Optimize empty tuples to unit constants in MIR #8237
Conversation
PR SummaryIntroduces unit-aware handling across MIR building and simplification.
Written by Cursor Bugbot for commit f0ef5be. This will update automatically on new commits. Configure here. |
🤖 Augment PR SummarySummary: Canonicalizes empty tuple construction in HashQL MIR and optimizes it into unit ( Changes:
Technical Notes: This makes unit values flow as constants earlier, reducing MIR noise and improving downstream pass stability. 🤖 Was this summary useful? React with 👍 or 👎 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review completed. No suggestions at this time.
Comment augment review to trigger a new review at any time.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## bm/be-197-hashql-implement-inlining #8237 +/- ##
=======================================================================
+ Coverage 76.02% 81.14% +5.12%
=======================================================================
Files 288 191 -97
Lines 42866 28548 -14318
Branches 1059 773 -286
=======================================================================
- Hits 32587 23166 -9421
+ Misses 9916 5122 -4794
+ Partials 363 260 -103
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merging this PR will not alter performance
Comparing |
a01405e to
f6a654b
Compare
c391344 to
e4333c8
Compare
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
f6a654b to
ebf1893
Compare
e4333c8 to
f169485
Compare
f169485 to
d9a54d7
Compare
ebf1893 to
1046b08
Compare
d9a54d7 to
20c52d2
Compare
1046b08 to
01aa550
Compare
20c52d2 to
c3200c0
Compare
01aa550 to
8002918
Compare
8002918 to
f0ef5be
Compare
c3200c0 to
7e32c71
Compare

🌟 What is the purpose of this PR?
This PR optimizes empty tuple handling in the MIR by simplifying empty tuple aggregates to unit constants and fixing tuple type handling in the body builder macro.
🔍 What does this change?
From<!>implementation forOperand<'_>to support empty tuplesPre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR:
🛡 What tests cover this?
empty_tuple_to_unit()to verify the optimization❓ How to test this?