BE-197: Implement MIR inline pass for HashQL #8236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
indietyp
force-pushed
the
bm/be-267-hashql-do-not-reset-the-scratch-space-but-instead-use-scopes
branch
from
08c3e40 to
f088349
Compare
indietyp
force-pushed
the
bm/be-197-hashql-implement-inlining
branch
from
d9a54d7 to
20c52d2
Compare
TimDiekmann
approved these changes
Jan 17, 2026
| "lint:clippy": "just clippy", | ||
| "test:codspeed": "cargo codspeed run -p hashql-core", | ||
| "test:miri": "cargo miri nextest run -- co_sort try_scan heap::transfer stable_empty_slice", | ||
| "test:miri": "cargo miri nextest run -- co_sort try_scan heap::transfer stable_empty_slice id::slice tarjan::tests::members", |
Member
There was a problem hiding this comment.
I wonder if we just generally run Miri on all tests
Member
Author
There was a problem hiding this comment.
i can give it a try next time, I didnt because of the time it takes to run, but let me check if that is still true
indietyp
force-pushed
the
bm/be-197-hashql-implement-inlining
branch
from
20c52d2 to
c3200c0
Compare
indietyp
force-pushed
the
bm/be-267-hashql-do-not-reset-the-scratch-space-but-instead-use-scopes
branch
from
f088349 to
427eda4
Compare
graphite-app
bot
changed the base branch from
bm/be-267-hashql-do-not-reset-the-scratch-space-but-instead-use-scopes
to
graphite-base/8236
indietyp
force-pushed
the
bm/be-197-hashql-implement-inlining
branch
from
c3200c0 to
7e32c71
Compare
indietyp
force-pushed
the
graphite-base/8236
branch
from
427eda4 to
c1ba012
Compare
indietyp
changed the base branch from
graphite-base/8236
to
bm/be-267-hashql-do-not-reset-the-scratch-space-but-instead-use-scopes
Base automatically changed from
bm/be-267-hashql-do-not-reset-the-scratch-space-but-instead-use-scopes
to
main
January 17, 2026 18:03
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌟 What is the purpose of this PR?
Implements a function inlining pass for HashQL's MIR (Mid-level Intermediate Representation). The pass reduces function call overhead and enables further optimizations by replacing call sites with the callee's body. It uses a two-phase approach: heuristic-based normal inlining followed by aggressive inlining for filter closures in graph read pipelines.
🔍 What does this change?
Pre-Merge Checklist 🚀
🚢 Has this modified a publishable library?
This PR:
📜 Does this require a change to the docs?
The changes in this PR:
🕸️ Does this require a change to the Turbo Graph?
The changes in this PR: