Upgrade Ruby to 3.1.0 #1881

salbertson · 2025-12-04T18:29:27Z

This will also use a dedicated queue for Rubocop v1.81.7.

Copilot

Pull request overview

This PR upgrades Ruby from version 2.7.1 to 3.1.0, updating dependencies and modifying code to ensure compatibility with Ruby 3.1.0's stricter requirements around keyword arguments and standard library changes.

Key changes:

Ruby version upgraded from 2.7.1 to 3.1.0 across all configuration files
Dependency versions updated in Gemfile and Gemfile.lock to Ruby 3.1.0-compatible versions
Code updated to handle Ruby 3.1.0's stricter keyword argument passing requirements and removal of static_facade from attr_extras 7.x

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
.ruby-version	Updated Ruby version from 2.7.1 to 3.1.0
Gemfile	Updated Ruby version and pinned gem versions with pessimistic version constraints for Ruby 3.1.0 compatibility
Gemfile.lock	Updated all gem versions to Ruby 3.1.0-compatible releases
circle.yml	Updated Docker images: Ruby 2.7.1 → 3.1, PostgreSQL 9.5 → 14.0, Redis 5.0.7 → 6.2
config/boot.rb	Added `require "logger"` for Ruby 3.1.0 compatibility (Logger no longer auto-loaded)
bin/webpack	Added `require "logger"` for Ruby 3.1.0 compatibility
spec/spec_helper.rb	Added `require "logger"` for Ruby 3.1.0 compatibility
spec/presenters/plan_presenter_spec.rb	Added double splat operator (`**`) when passing hashes to keyword argument initializers
spec/models/plan_selector_spec.rb	Added double splat operator (`**`) when passing hashes to keyword argument initializers
app/services/report_invalid_config.rb	Replaced `static_facade :call` with explicit class method (attr_extras 7.x compatibility)
app/services/rebuild_pull_request.rb	Replaced `static_facade :call` with explicit class method (attr_extras 7.x compatibility)
app/services/deactivate_repo.rb	Replaced `static_facade :call` with explicit class method (attr_extras 7.x compatibility)
app/services/build_config.rb	Replaced `static_facade :call` with explicit class method (attr_extras 7.x compatibility)
app/queries/recent_builds_by_repo_query.rb	Replaced `static_facade :call` with explicit class method (attr_extras 7.x compatibility)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-04T19:27:46Z

Gemfile

+  gem "dotenv-rails", "~> 2.7.5"
+  gem "foreman", "~> 0.87.0"
+  gem "listen", "~> 3.9.0"
+  gem "rspec-rails", "~> 4.0.0.beta4"


The version constraint ~> 4.0.0.beta4 should be updated to ~> 4.0.0 to reflect the stable version 4.0.2 that's actually being used in Gemfile.lock. Using a beta version constraint when a stable release is available is misleading.

Suggested change

gem "rspec-rails", "~> 4.0.0.beta4"

gem "rspec-rails", "~> 4.0.0"

Seems like a valid comment. Is there a reason we want the beta4 or the upgrade is just not part of this PR?

gylaz · 2025-12-05T22:10:05Z

Gemfile

+  gem "dotenv-rails", "~> 2.7.5"
+  gem "foreman", "~> 0.87.0"
+  gem "listen", "~> 3.9.0"
+  gem "rspec-rails", "~> 4.0.0.beta4"


Seems like a valid comment. Is there a reason we want the beta4 or the upgrade is just not part of this PR?

gylaz · 2025-12-05T22:11:20Z

app/services/build_config.rb

@@ -1,5 +1,11 @@
 class BuildConfig
-  static_facade :call
+  def self.call(hound_config:, name:, owner:)


Do we want to add a newline between static_facade and new method def?

We removed static_facade. What am I missing?

gylaz · 2025-12-05T22:12:49Z

spec/models/plan_selector_spec.rb


      expect(plan_selector.previous_plan).
-        to eq StripePlan.new(StripePlan::PLANS[2])
+        to eq StripePlan.new(**StripePlan::PLANS[2])


What does the ** do?

This is converting a Stripe plan hash to keyword arguments. Ruby no longer supports passing a hash, we need to use ** to convert.

irb(main):002* def wat(one:, two:) irb(main):003* puts one irb(main):004* puts two irb(main):005> end => :wat irb(main):006> wat({one: 1, two: 2}) (irb):2:in `wat': wrong number of arguments (given 1, expected 0; required keywords: one, two) (ArgumentError) from (irb):6:in `<main>' from /Users/scott/.rbenv/versions/3.1.0/lib/ruby/gems/3.1.0/gems/irb-1.15.3/exe/irb:9:in `<top (required)>' from /Users/scott/.rbenv/versions/3.1.0/bin/irb:25:in `load' from /Users/scott/.rbenv/versions/3.1.0/bin/irb:25:in `<main>' irb(main):007> wat(**{one: 1, two: 2}) 1 2 => nil

gylaz · 2025-12-05T22:13:12Z

app/models/linter/rubocop.rb

+      else
+        super
+      end
+    end


Why did you need to add this private method?

This overrides enqueue_job and allows us to process specific versions of Rubocup with dedicated queues. It's our way of deciding which linter app processes the job.

hound · 2025-12-06T17:22:15Z

spec/models/linter/rubocop_spec.rb

+        commit_file = build_commit_file(filename: "lib/a.rb")
+        allow(linter).to receive(:version).and_return("1.81.7")
+        job_setter = double("job_setter")
+        allow(LintersJob).to receive(:set).with(queue: "rubocop-1.81.7").and_return(job_setter)


Line is too long. [95/80]

salbertson · 2025-12-06T17:22:45Z

app/models/linter/rubocop.rb

 module Linter
  class Rubocop < Base
    FILE_REGEXP = /.+(\.rb|\.rake|\.jbuilder)|(Gemfile|Rakefile|Podfile)\z/
+    VERSIONS_WITH_DEDICATED_QUEUES = %w[1.81.7].freeze


@gylaz let's use a version that's not officially supported in case there are issues with the linter app.

salbertson added 10 commits December 4, 2025 07:58

Lock down gem versions

5dbc67b

Upgrade Ruby to 3.1.0 and upgrade rails

0035200

Lock oauth2 to < 2.0 and upgrade all gems

e9ce78d

Upgrade Nokogiri to support Ruby 3.1 and HTML4

dfac291

Make sure logger is required and lock down psych version to < 4

6b6c542

Upgrade all gems

13f406a

Fix named argument issues and upgrade factory_bot_rails

4ac0307

Upgrade attr_extras and forward named arguments correctly

707152a

Use newer Circle docker images

680add2

Sort gems and break up long lines

815ab61

salbertson force-pushed the upgrade-rails-and-ruby branch from 5818df6 to c9e71d6 Compare December 4, 2025 18:53

Require logger in time for webpack

16c7708

salbertson force-pushed the upgrade-rails-and-ruby branch from c9e71d6 to 16c7708 Compare December 4, 2025 19:01

salbertson added 2 commits December 4, 2025 11:11

Upgrade selenium-webdriver

4d7531d

Upgrade capybara and selenium-webdriver to manage chromdriver versions

952288e

salbertson requested a review from Copilot December 4, 2025 19:23

salbertson self-assigned this Dec 4, 2025

salbertson requested a review from gylaz December 4, 2025 19:23

Copilot started reviewing on behalf of salbertson December 4, 2025 19:23 View session

Copilot finished reviewing on behalf of salbertson December 4, 2025 19:26

Copilot AI reviewed Dec 4, 2025

View reviewed changes

salbertson added 2 commits December 4, 2025 12:31

Upgrade Sidekiq to work with Ruby 3.1.0

95c2270

Use a dedicated queue for rubocop v1.22.1

4196496

gylaz approved these changes Dec 5, 2025

View reviewed changes

Use a dedicated queue for Rubocop 1.81.7

32e909b

hound bot reviewed Dec 6, 2025

View reviewed changes

salbertson commented Dec 6, 2025

View reviewed changes

salbertson force-pushed the upgrade-rails-and-ruby branch from 88c0abc to 32e909b Compare December 6, 2025 18:27

	gem "rspec-rails", "~> 4.0.0.beta4"
	gem "rspec-rails", "~> 4.0.0"

Upgrade Ruby to 3.1.0 #1881

Are you sure you want to change the base?

Upgrade Ruby to 3.1.0 #1881

Uh oh!

Conversation

salbertson commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hound bot Dec 6, 2025

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

salbertson commented Dec 4, 2025 •

edited

Loading