-
Notifications
You must be signed in to change notification settings - Fork 394
Upgrade Ruby to 3.1.0 #1881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
salbertson
wants to merge
18
commits into
master
Choose a base branch
from
upgrade-rails-and-ruby
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+382
−288
Open
Upgrade Ruby to 3.1.0 #1881
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5dbc67b
Lock down gem versions
salbertson 0035200
Upgrade Ruby to 3.1.0 and upgrade rails
salbertson e9ce78d
Lock oauth2 to < 2.0 and upgrade all gems
salbertson dfac291
Upgrade Nokogiri to support Ruby 3.1 and HTML4
salbertson 6b6c542
Make sure logger is required and lock down psych version to < 4
salbertson 13f406a
Upgrade all gems
salbertson 4ac0307
Fix named argument issues and upgrade factory_bot_rails
salbertson 707152a
Upgrade attr_extras and forward named arguments correctly
salbertson 680add2
Use newer Circle docker images
salbertson 815ab61
Sort gems and break up long lines
salbertson 16c7708
Require logger in time for webpack
salbertson 4d7531d
Upgrade selenium-webdriver
salbertson 952288e
Upgrade capybara and selenium-webdriver to manage chromdriver versions
salbertson 95c2270
Upgrade Sidekiq to work with Ruby 3.1.0
salbertson 4196496
Use a dedicated queue for rubocop v1.22.1
salbertson 32e909b
Use a dedicated queue for Rubocop 1.81.7
salbertson 4a31656
Try locking down the API version
salbertson 2f0bc94
Pin Stripe API version
salbertson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.7.1 | ||
| 3.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,59 +1,62 @@ | ||
| source "https://rubygems.org" | ||
|
|
||
| ruby "2.7.1" | ||
| ruby "3.1.0" | ||
|
|
||
| gem "active_link_to" | ||
| gem "active_model_serializers", "0.10.10" | ||
| gem "administrate", "0.16.0" | ||
| gem "analytics-ruby", "~> 2.2.2", require: "segment/analytics" | ||
| gem "attr_extras" | ||
| gem "autoprefixer-rails" | ||
| gem "bourbon", "~> 5.0" | ||
| gem "email_validator" | ||
| gem "faraday", "~> 1.0" | ||
| gem "haml-rails", "~> 2.0" | ||
| gem "high_voltage" | ||
| gem "inifile" | ||
| gem "inline_svg" | ||
| gem "jquery-rails", ">= 4.2.0" | ||
| gem "jwt" | ||
| gem "neat", "~> 1.9" | ||
| gem "nokogiri", ">= 1.8.2" | ||
| gem "octokit" | ||
| gem "omniauth-github" | ||
| gem "omniauth-rails_csrf_protection" | ||
| gem "active_link_to", "~> 1.0.5" | ||
| gem "active_model_serializers", "~> 0.10.10" | ||
| gem "administrate", "~> 0.16.0" | ||
| gem "analytics-ruby", "~> 2.2.8", require: "segment/analytics" | ||
| gem "attr_extras", "~> 7.1.0" | ||
| gem "autoprefixer-rails", "~> 10.2.5" | ||
| gem "bourbon", "~> 5.1.0" | ||
| gem "email_validator", "~> 2.0.1" | ||
| gem "faraday", "~> 1.0.0" | ||
| gem "haml-rails", "~> 2.0.1" | ||
| gem "high_voltage", "~> 3.1.2" | ||
| gem "inifile", "~> 3.0.0" | ||
| gem "inline_svg", "~> 1.7.1" | ||
| gem "jquery-rails", "~> 4.4.0" | ||
| gem "jwt", "~> 2.2.1" | ||
| gem "neat", "~> 1.9.1" | ||
| gem "nokogiri", "~> 1.16.0" | ||
| gem "oauth2", "< 2.0" | ||
| gem "octokit", "~> 4.16.0" | ||
| gem "omniauth-github", "~> 1.4.0" | ||
| gem "omniauth-rails_csrf_protection", "~> 0.1.2" | ||
| gem "paranoia", "~> 2.4.2" | ||
| gem "pathspec" | ||
| gem "pg" | ||
| gem "puma" | ||
| gem "rails", "~> 6.0.3" | ||
| gem "sentry-raven" | ||
| gem "sidekiq" | ||
| gem "sinatra", "~> 2.0" | ||
| gem "stripe" | ||
| gem "uglifier", ">= 2.7.2" | ||
| gem "webpacker" | ||
| gem "pathspec", "~> 0.2.1" | ||
| gem "pg", "~> 1.2.2" | ||
| gem "psych", "< 4.0" | ||
| gem "puma", "~> 5.3.2" | ||
| gem "rails", "~> 6.0.4" | ||
| gem "sentry-raven", "~> 3.0.0" | ||
| gem "sidekiq", "~> 6.5.12" | ||
| gem "sinatra", "~> 2.0.8" | ||
| gem "stripe", "~> 5.15.0" | ||
| gem "uglifier", "~> 4.2.0" | ||
| gem "webpacker", "~> 4.2.2" | ||
| gem "webpacker-react", "~> 1.0.0.beta.1" | ||
|
|
||
| group :staging, :production do | ||
| gem "rack-timeout" | ||
| gem "rails_12factor" | ||
| gem "rack-timeout", "~> 0.6.0" | ||
| gem "rails_12factor", "~> 0.0.3" | ||
| end | ||
|
|
||
| group :development, :test do | ||
| gem "bundler-audit", require: false | ||
| gem "byebug" | ||
| gem "dotenv-rails" | ||
| gem "foreman" | ||
| gem "listen" | ||
| gem "rspec-rails", ">= 4.0.0.beta4" | ||
| gem "bundler-audit", "~> 0.6.1", require: false | ||
| gem "byebug", "~> 11.1.1" | ||
| gem "dotenv-rails", "~> 2.7.5" | ||
| gem "foreman", "~> 0.87.0" | ||
| gem "listen", "~> 3.9.0" | ||
| gem "rspec-rails", "~> 4.0.0.beta4" | ||
| end | ||
|
|
||
| group :test do | ||
| gem "capybara" | ||
| gem "factory_bot_rails" | ||
| gem "launchy" | ||
| gem "selenium-webdriver", ">= 4.0.0.alpha4" | ||
| gem "shoulda-matchers" | ||
| gem "webmock" | ||
| gem "capybara", "~> 3.39.0" | ||
| gem "factory_bot_rails", "~> 6.2.0" | ||
| gem "launchy", "~> 2.4.3" | ||
| gem "matrix", "~> 0.4.2" | ||
| gem "selenium-webdriver", "~> 4.20.0" | ||
| gem "shoulda-matchers", "~> 4.2.0" | ||
| gem "webmock", "~> 3.8.2" | ||
| end | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The version constraint
~> 4.0.0.beta4should be updated to~> 4.0.0to reflect the stable version 4.0.2 that's actually being used in Gemfile.lock. Using a beta version constraint when a stable release is available is misleading.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a valid comment. Is there a reason we want the
beta4or the upgrade is just not part of this PR?