Don't apply scale twice when using fractional scaling #2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lenemter
approved these changes
Nov 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using fractional scaling actor sizes, margins, monitor geometry, etc. are already in logical units, i.e. with the scale applied so manually multiplying with the scale again will result in it being applied twice.
In the future this will probably be the only mode (e.g. GNOME doesn't support per monitor scaling for its Shell UI without 'scale-monitor-framebuffer' because they argue it's not worth the effort given that it will be not needed in the future: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/1864) which will then let us remove all our custom scale handling but until then this introduces no regressions while improving the behavior for fractional scale enabled.
Fixes #2412