Add Shell#getZoom() #2930
Merged
Add Shell#getZoom() #2930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HeikoKlare
reviewed
Jan 9, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
What's the purpose of this renaming?
Contributor
Author
Since #2863 (comment) in this comment youhad requested to expose the API with a better name that makes sense, i.e. |
amartya4256
force-pushed
the
amartya4256/rename_getZoom
branch
2 times, most recently
from
d10241e to
fc87e89
Compare
HeikoKlare
reviewed
Jan 12, 2026
bundles/org.eclipse.swt/Eclipse SWT/cocoa/org/eclipse/swt/widgets/Shell.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
amartya4256/rename_getZoom
branch
from
fc87e89 to
e40ae0e
Compare
Contributor
HeikoKlare
force-pushed
the
amartya4256/rename_getZoom
branch
from
e40ae0e to
45e6f13
Compare
HeikoKlare
changed the title
HeikoKlare
force-pushed
the
amartya4256/rename_getZoom
branch
from
45e6f13 to
c5221e6
Compare
HeikoKlare
approved these changes
Jan 12, 2026
Contributor
HeikoKlare
left a comment
HeikoKlare
left a comment
There was a problem hiding this comment.
I've fixed the compilation error on MacOS (missing import) and faulty commit messages. I also updated the outdated PR title and description. With that, the PR is fine for me.
@akoch-yatta can you please also have a look?
After merging this, we also need to add a N&N for the new API.
This commit renames the method Widget#getZoom to getAutoscalingZoom since this methods return the value of the zoom based on the autoscaling technique, i.e. quarter, half, etc and whether autoscaling is enabled or disabled.
This commit adds an API Shell#getZoom() which returns the native zoom of the shell.
HeikoKlare
force-pushed
the
amartya4256/rename_getZoom
branch
from
c5221e6 to
aef7bf3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
Shell#getZoom()method to make the zoom of a shell as considered by the OS available to consumers. Currently, there is a (undocumented) data field on controls in the Windows implementation for this (SHELL_ZOOM). And for other operating system (which only use a static zoom value for everything), the value is provided internally viaDPIUtil#getNativeDeviceZoom()and may also be calculated fromDevice#getDPI().It also serves as a preparation for allowing explicit disablement of auto-scaling for specific controls as proposed with #2863, which requires access to the shell's zoom to custom-zoom auto-scale-disabled controls.
This PR also renames the method Widget#getZoom to getAutoscalingZoom since this methods return the value of the zoom based on the autoscaling technique, i.e. quarter, half, etc and whether autoscaling is enabled or disabled, and would conflict with the newly added
Shell#getZoom()method.Note: This change has been made using Eclipse refactoring tool.