Skip to content

Conversation

@amartya4256
Copy link
Contributor

@amartya4256 amartya4256 commented Dec 9, 2025

This PR provides a new API setAutoscaleDisabled to provide a better means of disabling autoscaling at widget level across all the platforms. The current implementation is intended to return a false when this method is called in cocoa and GTK and only perform an action win32 and return since we do not support widget level autoscaling control on GTK and cocoa yet.

The convention of the method is as follows:

  1. Takes a boolean parameter for disabling or enabling autoscale
  2. returns true if successful (in case of win32) otherwise false (in case of GTK and cocoa)

Things to be done:

  • Usage of different autoscaling modes as enabled, disabled and disabled_cascaded, etc
  • Testing with GEF to see how it impacts.

depends on #2930

@eclipse-platform-bot
Copy link
Contributor

eclipse-platform-bot commented Dec 9, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF

Warning

🚧 This PR cannot be modified by maintainers because edits are disabled or it is created from an organization repository. To obtain the required changes apply the git patch manually as an additional commit.

Git patch
From 985988b5290c07034647310b3fdbf3bbb5212354 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 30 Dec 2025 08:42:22 +0000
Subject: [PATCH] Version bump(s) for 4.39 stream


diff --git a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
index 84f618f2b6..3dccebb562 100644
--- a/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
+++ b/binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF
@@ -3,7 +3,7 @@ Fragment-Host: org.eclipse.swt;bundle-version="[3.128.0,4.0.0)"
 Bundle-Name: %fragmentName
 Bundle-Vendor: %providerName
 Bundle-SymbolicName: org.eclipse.swt.win32.win32.x86_64; singleton:=true
-Bundle-Version: 3.132.0.qualifier
+Bundle-Version: 3.132.100.qualifier
 Bundle-ManifestVersion: 2
 Bundle-Localization: fragment
 Export-Package: 
-- 
2.52.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

github-actions bot commented Dec 9, 2025

Test Results

  176 files  ±0    176 suites  ±0   27m 50s ⏱️ + 1m 7s
4 677 tests ±0  4 655 ✅ ±0  22 💤 ±0  0 ❌ ±0 
  482 runs  ±0    476 ✅ ±0   6 💤 ±0  0 ❌ ±0 

Results for commit 2b5c0a7. ± Comparison against base commit 8afb3c5.

♻️ This comment has been updated with latest results.

@HeikoKlare
Copy link
Contributor

@amartya4256 can you please add a meaningful title and description to the PR, even if it's still a draft?

@amartya4256 amartya4256 changed the title WIP Add setAutoscaleDisabled API to provide a better means to disabling autoscaling at widget level Dec 9, 2025
@amartya4256 amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch 2 times, most recently from cb3cc53 to 2a1545f Compare December 23, 2025 09:44
@akoch-yatta akoch-yatta force-pushed the amartya4256/set_autoscale_disabled_api branch from 2a1545f to f5b90b2 Compare December 30, 2025 08:38
@amartya4256 amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch 7 times, most recently from 8ff51cb to 85a74d1 Compare January 2, 2026 13:58
@amartya4256 amartya4256 marked this pull request as ready for review January 2, 2026 14:16
@amartya4256 amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch from 85a74d1 to d858871 Compare January 6, 2026 12:44
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2026

Test Results (macos)

   54 files  ±0     54 suites  ±0   8m 55s ⏱️ + 2m 6s
4 513 tests ±0  4 270 ✅ ±0  243 💤 ±0  0 ❌ ±0 
  104 runs  ±0    104 ✅ ±0    0 💤 ±0  0 ❌ ±0 

Results for commit ddd5eab. ± Comparison against base commit 892be33.

♻️ This comment has been updated with latest results.

@amartya4256 amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch 2 times, most recently from 2c97d55 to ddd5eab Compare January 6, 2026 13:59
@amartya4256 amartya4256 mentioned this pull request Jan 12, 2026
@HeikoKlare
Copy link
Contributor

@amartya4256 since the dependent PR is merged, this can/should be rebased on master now

@amartya4256 amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch 2 times, most recently from 1d665b4 to c4655bd Compare January 13, 2026 13:30
Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not tested yet, but the code looks fine at a first glance. For now I have some comments regarding code style and documentation.

@amartya4256 amartya4256 force-pushed the amartya4256/set_autoscale_disabled_api branch from c4655bd to 3517a82 Compare January 13, 2026 17:01
@akoch-yatta akoch-yatta force-pushed the amartya4256/set_autoscale_disabled_api branch from 3517a82 to 7834fb1 Compare January 14, 2026 16:26
This commit adds an API to set Autoscaling Modes using the new enum
AutoscalingMode with types Enabled, Disabled and Disabled_Inherited.
Moreover, it also provides an API Shell#getNativeZoom to still make the
consumer be able to obtain the actual zoom at a screen. These features
are only enabled on win32 and will not perform any action on other
platforms if called.
@akoch-yatta akoch-yatta force-pushed the amartya4256/set_autoscale_disabled_api branch from 7834fb1 to 2b5c0a7 Compare January 14, 2026 16:26
Copy link
Contributor

@akoch-yatta akoch-yatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I tested it with the current implementation in GEF that uses the existing DATA_ fields and adapted it with the new API methods to ensure it still works as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Concept] Proper implementation of autoscale disablement for part of the application

4 participants