feat(dashboard): sidebar group settings #3125
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabjanvucina
requested changes
Dec 8, 2025
Member
fabjanvucina
left a comment
fabjanvucina
left a comment
There was a problem hiding this comment.
@rpavlini just my 2 cents regarding the UI for the setup banner:
- It would look nicer with a larger bottom margin, it looks too clamped down on top of the items below it
- I would remove the icon from the top left corner since I'm not really sure that it adds value to the readability of the banner. It would look better in my opinion if the text and the button were aligned to the left with the border of the banner
fabjanvucina
requested changes
Dec 8, 2025
| label: 'General', | ||
| path: RoutePath.SETTINGS, | ||
| }, | ||
| { icon: <KeyRound size={16} strokeWidth={1.5} />, label: 'API Keys', path: RoutePath.KEYS }, |
Member
There was a problem hiding this comment.
Just curious, what was the idea behind moving the "API Keys" page to the "Settings" group?
I think we should further discuss whether we even need to have a separate "Settings" section. I'm inclined to say that we don't because all items in the sidebar are organization-related and there isn't a clear distinction in my opinion on why these pages would be considered settings. but I'm open to hear a different opinion.
Semi-related UI suggestions for the sidebar:
- The section heading should have the same padding as the section item icons, it looks cleaner
- The gap between sections should be smaller
Signed-off-by: rpavlini <[email protected]>
Signed-off-by: rpavlini <[email protected]>
Signed-off-by: rpavlini <[email protected]>
rpavlini
force-pushed
the
feat/sidebar-settings-group
branch
from
6473e68 to
5bd0cca
Compare
Signed-off-by: rpavlini <[email protected]>
rpavlini
force-pushed
the
feat/sidebar-settings-group
branch
from
5bd0cca to
71b2614
Compare
rpavlini
changed the title
rpavlini
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Groups settings pages under
Settingsin the sidebar.Adds a more user friendly setup banner with a link.
Documentation
Screenshots