Skip to content

fix: use _resetForTesting() consistently to prevent flaky tests #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
G-hoon wants to merge 1 commit into
base: dev
Choose a base branch
from
+9 −61
Open

fix: use _resetForTesting() consistently to prevent flaky tests #879

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 0 additions & 52 deletions bun.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 2 additions & 3 deletions src/features/claude-code-session-state/state.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,9 +92,8 @@ describe("claude-code-session-state", () => {
expect(getMainSessionID()).toBe(mainID)
})

test.skip("should return undefined when not set", () => {
// #given - not set
// TODO: Fix flaky test - parallel test execution causes state pollution
test("should return undefined when not set", () => {
// #given - not set (state is reset in beforeEach)
// #then
expect(getMainSessionID()).toBeUndefined()
})
Expand Down
13 changes: 7 additions & 6 deletions src/hooks/keyword-detector/index.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ describe("keyword-detector registers to ContextCollector", () => {
afterEach(() => {
logSpy?.mockRestore()
getMainSessionSpy?.mockRestore()
_resetForTesting()
})

function createMockPluginInput() {
Expand Down Expand Up @@ -97,7 +98,7 @@ describe("keyword-detector session filtering", () => {
let logSpy: ReturnType<typeof spyOn>

beforeEach(() => {
setMainSession(undefined)
_resetForTesting()
logCalls = []
logSpy = spyOn(sharedModule, "log").mockImplementation((msg: string, data?: unknown) => {
logCalls.push({ msg, data })
Expand All @@ -106,7 +107,7 @@ describe("keyword-detector session filtering", () => {

afterEach(() => {
logSpy?.mockRestore()
setMainSession(undefined)
_resetForTesting()
})

function createMockPluginInput(options: { toastCalls?: string[] } = {}) {
Expand Down Expand Up @@ -242,7 +243,7 @@ describe("keyword-detector word boundary", () => {
let logSpy: ReturnType<typeof spyOn>

beforeEach(() => {
setMainSession(undefined)
_resetForTesting()
logCalls = []
logSpy = spyOn(sharedModule, "log").mockImplementation((msg: string, data?: unknown) => {
logCalls.push({ msg, data })
Expand All @@ -251,7 +252,7 @@ describe("keyword-detector word boundary", () => {

afterEach(() => {
logSpy?.mockRestore()
setMainSession(undefined)
_resetForTesting()
})

function createMockPluginInput(options: { toastCalls?: string[] } = {}) {
Expand Down Expand Up @@ -339,7 +340,7 @@ describe("keyword-detector agent-specific ultrawork messages", () => {
let logSpy: ReturnType<typeof spyOn>

beforeEach(() => {
setMainSession(undefined)
_resetForTesting()
logCalls = []
logSpy = spyOn(sharedModule, "log").mockImplementation((msg: string, data?: unknown) => {
logCalls.push({ msg, data })
Expand All @@ -348,7 +349,7 @@ describe("keyword-detector agent-specific ultrawork messages", () => {

afterEach(() => {
logSpy?.mockRestore()
setMainSession(undefined)
_resetForTesting()
})

function createMockPluginInput() {
Expand Down