fix: use _resetForTesting() consistently to prevent flaky tests #879
+9
−61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
mainSessionIDtests caused by state pollution in parallel test execution_resetForTesting()consistently across all test files that modify session stateChanges
src/hooks/keyword-detector/index.test.ts: ReplacesetMainSession(undefined)with_resetForTesting()in beforeEach/afterEach hookssrc/features/claude-code-session-state/state.test.ts: Un-skip the previously flaky testRoot Cause
Some test files were using
setMainSession(undefined)which only clears_mainSessionID, but_resetForTesting()also clearssubagentSessions. This inconsistency caused state pollution when tests run in parallel.Testing
bun test src/features/claude-code-session-state/state.test.ts src/hooks/keyword-detector/index.test.tsRan 5 consecutive test runs with 0 failures.
Fixes #848
Summary by cubic
Consistently reset session state in tests using _resetForTesting() to stop flaky mainSessionID failures and prevent state leaks across parallel runs. Fixes #848.
Written for commit 0d10bcd. Summary will update on new commits.