Skip to content

Conversation

@floern1
Copy link

@floern1 floern1 commented Nov 4, 2025

Hi,

recently the dataset that accompanies the ATLAS PUB note ATL-SOFT-PUB-2025-003 was approved and I would like to upload the corresponding files to the CERN opendata platform. The are located at /eos/atlas/atlascerngroupdisk/proj-simul/AF4/Development/FrozenShowerInputSamplesContinuousEnergy/PUB_note_DS/*

I was already in contact with Zach and created a record JSON skeleton that is the content of this merge request. I was told, that the file information can be added automatically, so I filled only the other entries. If you need more than that, please tell me so that I can add additional entries.

Cheers Florian

@zlmarshall
Copy link
Contributor

Just a quick note that the files are now all available in the staging area:

$ lt /eos/opendata/atlas/upload/voxelization_3761
total 25G
-rw-r--r--. 1 zmarshal zp 3.7G Nov 14 10:28 default_dataset_full_val.hdf5
-rw-r--r--. 1 zmarshal zp 8.5G Nov 14 10:29 regular_dataset_full_val.hdf5
-rw-r--r--. 1 zmarshal zp 3.7G Nov 14 10:30 default_dataset_full_trn.hdf5
-rw-r--r--. 1 zmarshal zp 8.5G Nov 14 10:31 regular_dataset_full_trn.hdf5

@psaiz psaiz force-pushed the ATLAS-ATL-SOFT-PUB-2025-003 branch from e539f08 to 03adff6 Compare November 19, 2025 14:14
@psaiz
Copy link
Contributor

psaiz commented Nov 19, 2025

Hi Florian,
Thanks for applying the suggestions. We have to make sure that the pipelines are happy before we can merge this. Most of the pipelines worked. The only one that failed was the commitlint, which looks at the message of the commit.

Would you mind amending the commit, to something like feat(records): adding ATLAS dataset for the PUB note ATL_SOFT_PUB-2025-03 ?

@floern1 floern1 changed the title Added a new record JSON skeleton for the Dataset that corresponds to the PUB note ATL-SOFT-PUB-2025-003 feat(records): adding ATLAS dataset for the PUB note ATL_SOFT_PUB-2025-03 Nov 19, 2025
@floern1
Copy link
Author

floern1 commented Nov 19, 2025

No Problem, done

@psaiz psaiz force-pushed the ATLAS-ATL-SOFT-PUB-2025-003 branch from c66b0d3 to 4c7adee Compare November 19, 2025 15:41
@psaiz
Copy link
Contributor

psaiz commented Nov 19, 2025

Hi Florian,
Thanks for your reply.
I'm afraid that I wasn't clear, sorry about that. We don't need to change the title of the pull request. We need to change the commit messages. I hope that you don't mind that I have just done it, and push it to your branch. Let's see if the pipelines are happy now.

@psaiz psaiz force-pushed the ATLAS-ATL-SOFT-PUB-2025-003 branch from 4c7adee to b19709f Compare November 19, 2025 15:45
@psaiz
Copy link
Contributor

psaiz commented Nov 19, 2025

Thanks @floern1 and @zlmarshall . The record looks good I've uploaded it to our qa instance. Would you mind confirming that it looks good to you as well?

The entry does not have a DOI. Should we create one, to make it easier to cite the data?

@zlmarshall
Copy link
Contributor

Thanks @psaiz ! I'll look at the QA entry ASAP; meanwhile, yes please, this should have a DOI so that it can be cited.

Best,
Zach

Copy link
Contributor

@zlmarshall zlmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick things I noticed while looking at the QA record. Thanks again @floern1 for putting this together!

@psaiz psaiz force-pushed the ATLAS-ATL-SOFT-PUB-2025-003 branch from 3e584bf to 0d74c55 Compare November 20, 2025 10:15
@psaiz
Copy link
Contributor

psaiz commented Nov 20, 2025

Hi,
I've merged the commits again, so that the pipelines would be happy.

There is only one open discussion left, with the link to gitlab. @zlmarshall, once you are happy with that discussion as well, could you please approve the request? I will then deploy it again on dev and qa, and, if there are no issues, also on prod.

@zlmarshall
Copy link
Contributor

Sounds good to me — thanks @psaiz !

@floern1
Copy link
Author

floern1 commented Nov 20, 2025

Do you think this here works?

https://gitlab.cern.ch/fernst/datasetshowcase

Copy link
Contributor

@zlmarshall zlmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks good to me.

@floern1
Copy link
Author

floern1 commented Nov 27, 2025

Hi, next monday there is a meeting, where I wanted to present the dataset. It would be nice if it could be online until then. It should be only clicking the merge-button, right? Or is there anything from my side that you are waiting for?

Best
Florian

@psaiz psaiz force-pushed the ATLAS-ATL-SOFT-PUB-2025-003 branch from b61bd48 to 0fc89b2 Compare December 2, 2025 08:42
@psaiz psaiz merged commit 65874ba into cernopendata:master Dec 2, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants