-
Notifications
You must be signed in to change notification settings - Fork 38
Allow computation and storage of height at W0 #229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
This is ready for Science Review, thanks @jameskent-metoffice |
jameskent-metoffice
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very simple change to one file. I have one query which I've commented in sci_geometric_constants_mod. Other than that I am happy that this passes science review.
|
Just commenting to say this is ready for code review @MatthewHambley, as I'm not sure exactly what is being picked up by notifications |
PR Summary
Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @MatthewHambley
We can already store the vertical height field at many function spaces, but the W0 function space is missing. This PR adds it in.
Linked to: MetOffice/lfric_apps#165
Code Quality Checklist
(Some checks are automatically carried out via the CI pipeline)
style guidelines
readability of the code
Testing
using this branch
acceptable (e.g. kgo changes)
tests, unit tests, etc.)
and have been allocated to an appropriate testing group (i.e. the
developer tests are for jobs which use a small amount of compute resource
and complete in a matter of minutes)
trac.log
Test Suite Results - lfric_core - height_w0/run1
Suite Information
Task Information
✅ succeeded tasks - 372
Security Considerations
Performance Impact
performance measurements have been conducted
AI Assistance and Attribution
of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
Simulation Systems AI policy
(including attribution labels)
Documentation
confirmed that it builds correctly
PSyclone Approval
interface, optimisation scripts, LFRic data structure code) then please
contact the
[email protected]
Sci/Tech Review
Please alert the code reviewer via a tag when you have approved the SR
Code Review