Skip to content

Conversation

@tommbendall
Copy link
Contributor

@tommbendall tommbendall commented Jan 20, 2026

PR Summary

Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @MatthewHambley

We can already store the vertical height field at many function spaces, but the W0 function space is missing. This PR adds it in.

Linked to: MetOffice/lfric_apps#165

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

  • I have performed a self-review of my own code
  • My code follows the project's
    style guidelines
  • Comments have been included that aid understanding and enhance the
    readability of the code
  • My changes generate no new warnings

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite
    using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and
    acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system
    tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource
    and have been allocated to an appropriate testing group (i.e. the
    developer tests are for jobs which use a small amount of compute resource
    and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - height_w0/run1

Suite Information

Item Value
Suite Name height_w0/run1
Suite User thomas.bendall
Workflow Start 2026-01-20T16:15:30
Groups Run developer
Dependency Reference Main Like
lfric_core tommbendall/lfric_core@TBendall/HeightW0 False
SimSys_Scripts MetOffice/[email protected] True

Task Information

✅ succeeded tasks - 372

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable
    performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance
    of Generative AI tool name (e.g., Met Office Github Copilot Enterprise,
    Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the
    Simulation Systems AI policy
    (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and
    confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel
    interface, optimisation scripts, LFRic data structure code) then please
    contact the
    [email protected]

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

@tommbendall tommbendall self-assigned this Jan 20, 2026
@github-actions github-actions bot added the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 20, 2026
@github-actions github-actions bot removed the cla-required The CLA has not yet been signed by the author of this PR - added by GA label Jan 20, 2026
@tommbendall tommbendall added the Linked Apps This PR is linked to a MetOffice/lfric_apps PR label Jan 20, 2026
@tommbendall tommbendall marked this pull request as ready for review January 21, 2026 13:45
@tommbendall tommbendall added the enhancement New feature or request label Jan 22, 2026
@tommbendall
Copy link
Contributor Author

This is ready for Science Review, thanks @jameskent-metoffice

@tommbendall tommbendall added this to the Spring 2026 milestone Jan 22, 2026
Copy link

@jameskent-metoffice jameskent-metoffice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a very simple change to one file. I have one query which I've commented in sci_geometric_constants_mod. Other than that I am happy that this passes science review.

@github-actions github-actions bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Jan 23, 2026
@tommbendall
Copy link
Contributor Author

Just commenting to say this is ready for code review @MatthewHambley, as I'm not sure exactly what is being picked up by notifications

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla-signed The CLA has been signed as part of this PR - added by GA enhancement New feature or request Linked Apps This PR is linked to a MetOffice/lfric_apps PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants