Allow outputting of vertical height in W0 and W2H function spaces

[tommbendall]

PR Summary

Sci/Tech Reviewer: @jameskent-metoffice
Code Reviewer: @MatthewHambley

This PR adds height_w0 and height_w2h diagnostics, which allows the vertical height to be output at W0 and W2H points, if requested (and if #164 is addressed for lfric_atm).

I have also taken the opportunity to do a small bit of tidying of gungho_diagnostics_driver_mod.F90

Linked to: MetOffice/lfric_core#229

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_apps - heights_more/run4

Suite Information

Item	Value
Suite Name	heights_more/run4
Suite User	thomas.bendall
Workflow Start	2026-01-21T10:07:40
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/[email protected]	True
jules	MetOffice/[email protected]	True
lfric_apps	tommbendall/lfric_apps@TBendall/HeightsMore	False
lfric_core	tommbendall/lfric_core@TBendall/HeightW0	True
moci	MetOffice/[email protected]	True
SimSys_Scripts	MetOffice/[email protected]	True
socrates	MetOffice/[email protected]	True
socrates-spectral	MetOffice/[email protected]	True
ukca	MetOffice/[email protected]	True

Task Information

✅ succeeded tasks - 1106

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[tommbendall]

This is ready for Science Review, thanks @jameskent-metoffice

[jameskent-metoffice]

This work adds the ability to output vertical height of W0 and W2H function spaces for gungho_model and lfric_atm. It is a relatively straightforward change, and it has been coded correctly. The file gungho_diagnostics_driver_mod.F90 has been tidied up as well. As all the tests pass, I'm happy this passes science review.

[tommbendall]

Just commenting to say this is ready for code review @MatthewHambley, as I'm not sure exactly what is being picked up by notifications