Cody/change entry name #657
Conversation
|
Gridiron Survivor Application
Project name: Gridiron Survivor Application
Only deployments on the production branch are activated automatically. If you'd like to activate this deployment, navigate to your deployments. Learn more about Appwrite Function deployments.
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| data, | ||
| ): Promise<void> => { | ||
| const { name } = data; | ||
| const entryId: string = entry; |
There was a problem hiding this comment.
Why do we need this variable?
There was a problem hiding this comment.
We don't, I'll fix it
| fireEvent.click(screen.getByTestId('edit-entry-name-button')); | ||
|
|
||
| const entryNameInput = screen.getByTestId('entry-name-input'); | ||
| const cancelButton = screen.getByLabelText('Cancel Editing'); |
There was a problem hiding this comment.
Do not grab elements by text. If the text changes, this test will fail. Instead, add data-testid attribute. This is a unique ID that won't ever change. On top of this, when we add localization, things won't always be in English.
| }); | ||
|
|
||
| const input = screen.getByTestId('entry-name-input'); | ||
| fireEvent.change(input, { target: { value: 'New Entry Name' } }); |
There was a problem hiding this comment.
Same here. Add a data-testid.
Closes #634
updateEntryNamefunction to update the Document in DBonSubmitfunction to callupdateEntryNameand update state