Fix plotting tests #284
Merged
Fix plotting tests #284
+46
−50
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stes
commented
Jan 17, 2026
Member
Author
|
works 
|
Member
Author
|
full test also runs. will rebase now on main, then ready to merge |
stes
force-pushed
the
stes/fix-plotting-test
branch
from
58f86b7 to
52b0cb8
Compare
Member
Author
|
tests should pass. if they do, ready to merge @MMathisLab |
MMathisLab
approved these changes
Jan 17, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The plotting tests had several bugs; figures were created, closed, but stale references to
axobjects used later on. This silently failed for a while now, but the windows tests in #281 (which used an interactive plotting backend) revealed the bug.This PR is a minimal edit to the test for fixing the order of fig/ax/close calls in the test.