Build, doc and one small code fix #658
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.NET 6 was deprecated so move to .NET 8 and possibly .NET 10 after it releases.
In C++/CLI skipped xUnit tests are skipped but they print out their skip message as red error messages. That's very scary and the bug is known in xUnit so for now the easiest workaround is to comment out the skipped tests.
Fixes 9172
barnson
reviewed
Oct 16, 2025
barnson
previously approved these changes
Oct 16, 2025
Contributor
|
.NET 10 is being released approx 11 November 2025 (i.e. in just over two weeks).
|
Member
|
@bevanweiss We talked about that during the last online meeting. |
When the wixnative.exe exits before the C# code sends the preamble, we'll get an exception that the stdin pipe is already closed. Turns out some commands did not wait for the preamble, so make them all wait to remove the race condition.
barnson
previously approved these changes
Nov 2, 2025
src/wix/test/WixToolsetTest.CoreIntegration/TestData/NoFileCompressed/data/test.txt
Outdated
Show resolved
Hide resolved
barnson
approved these changes
Nov 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.