Skip to content

Conversation

@yamilmedina
Copy link
Contributor

@yamilmedina yamilmedina commented Jan 23, 2026

https://wearezeta.atlassian.net/browse/WPB-22876


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

Issues

Running benchmarks needed some hacks in order to be run.

Causes (Optional)

Outdated since the last time we run, and new modules introduced.

Solutions

  • Add to the convention plugin the benchmark build type configs, so modules match the flavor.
  • Add docs about how to run the benchmarks
  • Fix benchmark with login, since new login was introduced last year.

Testing

Test Coverage (Optional)

  • I have added automated test to this contribution

How to Test

  • build the benchmark app as per instructions in new benchmark/README.md
  • run the benchmarks

PR Post Submission Checklist for internal contributors (Optional)

  • Wire's Github Workflow has automatically linked the PR to a JIRA issue

PR Post Merge Checklist for internal contributors

  • If any soft of configuration variable was introduced by this PR, it has been added to the relevant documents and the CI jobs have been updated.

References
  1. https://sparkbox.com/foundry/semantic_commit_messages
  2. https://github.com/wireapp/.github#usage
  3. E.g. feat(conversation-list): Sort conversations by most emojis in the title #SQPIT-764.

@sonarqubecloud
Copy link

@yamilmedina yamilmedina changed the title fix: benchmarks config and docs to run them (WPB-22876) fix: benchmarks configurations and docs on how to run them (WPB-22876) Jan 23, 2026
@yamilmedina yamilmedina added this pull request to the merge queue Jan 23, 2026
Merged via the queue into develop with commit 89b656e Jan 23, 2026
31 of 36 checks passed
@yamilmedina yamilmedina deleted the yamil/fix/benchmarks-configs branch January 23, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants