Modify hoverbox to allow keyboard tabbing, and remove surplus hidden … #1121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…link that is lending to confusing tabbing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…link that is lending to confusing tabbing.
How this addresses the issue
The current hoverbox responds oddly to keyboard tabbing. The expectation seems to be that the user will hover the main container. This does not work for keyboard tabbing, as the there is no tab element that matches the css properties. This pr updates the css to instead target focus-within, a newer css property with widespread support, that allows for any subelement in the hoverbox container to trigger the show the box css. This does not directly address the keyboard tabbing. Instead, the way the link to the news story is rendered is updated instead, so that now the title is properly a link, and a second hidden title is removed to reduce keyboard tabbing confusion. This allows tabbing to a sub-element, and triggering of the show the text css.
Testing steps