Skip to content

4.x: Refactor footer menus so that they do not render elements if empty, r… #1114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robgasc wants to merge 5 commits into
base: 4.x
Choose a base branch
from
+29 −154
Open

4.x: Refactor footer menus so that they do not render elements if empty, r… #1114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8499090
Refactor footer menus so that they do not render elements if empty, r…
robgasc Jan 23, 2026
b0b2ed7
Add actual logic to container check.
robgasc Jan 23, 2026
d717c39
Added missing endif and div
trubach Jan 29, 2026
b1f1d16
Merge branch '4.x' into 1113-empty-footer-menus-use
robgasc Jan 29, 2026
04a9e48
Moved divs outside of if statement so that the footer grid renders co…
trubach Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions scss/illinois-framework/_region.footer.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,8 @@ ilw-footer {
grid-template-columns: repeat(2,1fr);
grid-gap: 60px;
}
nav {
@include media-breakpoint-up(lg) {
margin-bottom: 1rem;
}
@include media-breakpoint-up(lg) {
margin-bottom: 1rem;
}

h2 {
Expand Down
44 changes: 0 additions & 44 deletions templates/block/block--footermenufourth.html.twig
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions templates/block/block--footermenusecond.html.twig
View file
Open in desktop

This file was deleted.

44 changes: 0 additions & 44 deletions templates/block/block--footermenuthird.html.twig
View file
Open in desktop

This file was deleted.

8 changes: 4 additions & 4 deletions ...es/block/block--footermenufirst.html.twig → .../block/block--system-menu-block.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@
#}
{%
set classes = [
'block',
'block-' ~ configuration.provider|clean_class,
'block-' ~ plugin_id|clean_class,
]
'block',
'block-' ~ configuration.provider|clean_class,
'block-' ~ plugin_id|clean_class,
]
%}
<div{{ attributes.addClass(classes) }}>
{{ title_prefix }}
Expand Down
37 changes: 23 additions & 14 deletions templates/region/region--footer.html.twig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,24 +121,33 @@
{% endfor %}
<a href="{{ login_logout_url }}" rel="nofollow">{{ login_logout_text }}</a>
</div>

{# This variable footermenus helps with initial render (render once), shortens the section for the menu footers and
enables checking if content is present. #}
{% set footermenus = [ drupal_entity('block', 'footermenufirst')|render,
drupal_entity('block', 'footermenusecond')|render,
drupal_entity('block', 'footermenuthird')|render,
drupal_entity('block', 'footermenufourth')|render ]
%}

{# if any footermenu rendered, show the container #}
{% if footermenus[0] is not empty or footermenus[1] is not empty or
footermenus[2] is not empty or footermenus[3] is not empty %}
<div class="footer-menus">
<div>
{% if drupal_entity('block', 'footermenufirst') %}
<nav aria-label="Campus Footer Links">{{ drupal_entity('block', 'footermenufirst') }}</nav>
{% endif %}
{% if drupal_entity('block', 'footermenusecond') %}
<nav aria-label="Campus Footer Links 2">{{ drupal_entity('block', 'footermenusecond') }}</nav>
{% endif %}
<div>{# Keep the div even if blank so that CSS grid works properly #}
{% if footermenus[0] is not empty or footermenus[1] is not empty%}
{{ footermenus[0] }}
{{ footermenus[1] }}
{% endif %}
</div>
<div>
{% if drupal_entity('block', 'footermenuthird') %}
<nav aria-label="Campus Footer Links 3">{{ drupal_entity('block', 'footermenuthird') }}</nav>
{% endif %}
{% if drupal_entity('block', 'footermenufourth') %}
<nav aria-label="Campus Footer Links 4">{{ drupal_entity('block', 'footermenufourth') }}</nav>
{% endif %}
<div>{# Keep the div even if blank so that CSS grid works properly #}
{% if footermenus[2] is not empty or footermenus[3] is not empty%}
{{ footermenus[2] }}
{{ footermenus[3] }}
{% endif %}
</div>
</div>
{% endif %}
{% if if_footer_google_translate ?? true %}
<div id="google_translate_element"></div>
<script>
Expand Down