chore: use FilterArray instead of compute::filter
#5941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joe Isaacs <[email protected]>
Signed-off-by: Joe Isaacs <[email protected]>
joseph-isaacs
changed the title
FilterArray instead of compute::filterFilterArray instead of compute::filter
joseph-isaacs
added
chore
gatesn
reviewed
Jan 13, 2026
| } | ||
|
|
||
| /// The mask used to filter the child array. | ||
| pub fn filter_mask(&self) -> &Mask { |
Contributor
There was a problem hiding this comment.
I really think you need to hide this / name it better / something. It's too much of a foot-gun to expose the unsliced mask
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.