refactor(store): rename feature to slice #373
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace 'feature' with 'slice' terminology in store package - Add combine() for explicit slice composition - Rename createFeatureSelector to createSelector - Move definePlayerFeature to @videojs/core/dom - Add Selector and Comparator types to core store - Update html and react packages with consistent exports
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
mihar-22
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs #363
Summary
Refactor
@videojs/storeto use "slice" terminology instead of "feature", with explicitcombine()primitive for composition. This separates generic store concepts from domain-specific player terminology.Changes
defineSlice,Slice,AnySlice)combine()as first-class slice composition primitivecreateFeatureSelector→createSelectordefinePlayerFeatureto@videojs/core/dom(=defineSlice<PlayerTarget>())SelectorandComparatortypes to core storeImplementation details
Package layering:
@videojs/store— generic primitives:defineSlice,combine,createStore@videojs/core/dom—definePlayerFeature(typed alias for player slices)@videojs/html/@videojs/react— re-export utilities, usecombineinternallyAPI change:
Testing
pnpm typecheck✓pnpm test✓ (461 tests)pnpm lint✓