timeout: use nix kill/setpgid to reduce unsafe #10120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mattsu2020
commented
Jan 8, 2026
mattsu2020
commented
- Replace libc::kill(getpid(), signal) and libc::setpgid(0, 0) in timeout with the nix equivalents, removing those unsafe blocks.
- Improves safety/readability by using higher‑level, checked APIs.
Replace unsafe `libc::kill` and `libc::setpgid` calls in the timeout utility with safer nix crate wrappers (`kill`, `getpid`, `setpgid`) to reduce unsafe code usage and improve overall code safety. This maintains functionality while leveraging Rust's type safety for signal and process group operations.
Reorder nix imports to alphabetical order in timeout.rs for better code organization and readability. No functional changes.
|
GNU testsuite comparison: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.