perf: optimize refcounting #2456
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the style of the stdlib for better performance of the refcounting code of `NickelValue`.
Contributor
Bencher Report
jneem
approved these changes
Dec 5, 2025
|
|
||
| fn decr_ref_count(&mut self) { | ||
| #[inline] | ||
| fn dec_ref_count(&self) { |
Member
There was a problem hiding this comment.
Is it not worthwhile to assert here that count != 0? (Naively, I'd expect this one to be more valuable than the other one, because it means the subtraction can't overflow)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #2455.
This commit mostly copies the style of the stdlib in
std::rc::Rc, in hope of gaining the same kind of optimizations. It does nullify the loss of #2455, and wins overall 5-7% on the OPL benchmark in runtime when compared to master. After a bit of experimentation, it seems that the[u8; 7]representation had to go for those optimizations to fire properly.