Create way to add key-value pairs to new sinks #4582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Nevermind! |
mcastorina
reviewed
Dec 5, 2025
Contributor
mcastorina
left a comment
mcastorina
left a comment
There was a problem hiding this comment.
Looks good! Feels kind of kludgey but it works.
Comment on lines
+149
to
+152
| // New key-value pairs cannot be ergonomically added directly to cores. logr has code to do it, but that code is not | ||
| // exported. Rather than replicating it ourselves, we indirectly use it by creating a temporary logger for the new | ||
| // core, adding the key-value pairs to the temporary logger, and then extracting the temporary logger's modified | ||
| // core. |
Contributor
There was a problem hiding this comment.
Is the "non-ergonomic way" you're referring to the Core.With method?
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Counterintuitively, a new sink added to an existing logger will not inherit the existing logger's key-value pairs. This has only caused a problem in practice with respect to a small number of known key-value pairs, so this PR creates a way to add specific key-value pairs to new sinks.
This will supersede #4579.
Checklist:
make test-community)?make lintthis requires golangci-lint)?