chore: move releases.json to new format #140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
obrusvit
reviewed
Jul 24, 2025
Contributor
obrusvit
left a comment
obrusvit
left a comment
There was a problem hiding this comment.
I believe we can merge it as it but two points to discuss:
- the only field missing is
"translations". Maybe we can add it later. - the names of the binaries in
trezor/datafollow slightly different naming convention by dropping the first 8 chars of the commit hash. Should we follow the established naming convention (without the commit has part) also in the new repository?
karliatto
force-pushed
the
chore/move-releases.json-to-new-format
branch
from
1847c3f to
74db1e3
Compare
Member
Author
Sure, I updated it to contain the "translations" as we agreed. Regarding the naming convention for the binaries I do noth have strong opinions, here I am just following the same we have right now. I also updated the script to check the new format for releases JSON. |
karliatto
changed the title
obrusvit
requested changes
Jul 28, 2025
Contributor
obrusvit
left a comment
obrusvit
left a comment
There was a problem hiding this comment.
Just one thing at this point:
translationsfield is not necessary fort1b1(legacy) as Model One doesn't support translations. We should either remove it or keep the field empty object.
Member
Author
Sure that makes a lot of sense, thanks for catching it. I added fixup commit changing |
obrusvit
previously approved these changes
Jul 28, 2025
karliatto
force-pushed
the
chore/move-releases.json-to-new-format
branch
from
a60e080 to
f931bcd
Compare
karliatto
force-pushed
the
chore/move-releases.json-to-new-format
branch
from
f931bcd to
739bdbe
Compare
obrusvit
approved these changes
Jul 29, 2025
vdovhanych
approved these changes
Jul 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating releases JSONs for all the FWs in legacy
releases.jsonfor all the models.Also updating the scripts so they check the revisions in the old files as well as in the new ones.
Related trezor/trezor-suite#19763