Remove unused TD_PRESTO_API and TD_PLAZMA_API environment variables from engage ROI reporting #418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These environment variables were originally required by pytd but are no longer needed in this project. Simplifying the configuration by removing unnecessary environment variable requirements from: - engage-box/roi_reporting/scripts/reporting_agent/events_master.py (documentation) - engage-box/roi_reporting/workflows/reporting_agent/report_preparation.dig (2 occurrences) - engage-box/roi_reporting/workflows/reporting_agent/revenue_generation.dig (1 occurrence)
These API endpoint configurations are no longer needed since the corresponding TD_PRESTO_API and TD_PLAZMA_API environment variables have been removed from the workflow files. Completing the cleanup of unused pytd-related settings.
iwbch
approved these changes
Jan 19, 2026
Contributor
iwbch
left a comment
iwbch
left a comment
There was a problem hiding this comment.
We have confirmed that it works in the environment where it is actually expected to be used, so I don't think there will be any problems.
Contributor
Author
|
Thanks for reviewin! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TD_PRESTO_APIandTD_PLAZMA_APIenvironment variable requirements from engage ROI reporting workflowsChanges
engage-box/roi_reporting/scripts/reporting_agent/events_master.py: RemovedTD_PRESTO_APIandTD_PLAZMA_APIfrom documentationengage-box/roi_reporting/workflows/reporting_agent/report_preparation.dig: Removed environment variables from two workflow stepsengage-box/roi_reporting/workflows/reporting_agent/revenue_generation.dig: Removed environment variables from revenue generation stepengage-box/roi_reporting/workflows/reporting_agent/config.yaml: Removed environment variablesTest plan