CI: create GitHub Release, multi-platform build, fix linux workflow #842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miredirex
changed the title
miredirex
reviewed
Jan 12, 2026
.github/workflows/linux.yml
Outdated
| push: | ||
| branches: | ||
| - master | ||
| - prerel |
Collaborator
There was a problem hiding this comment.
'prerel' branch hasn't been used in years, you can remove this
Comment on lines
88
to
89
| - name: Create GitHub Release | ||
| uses: softprops/action-gh-release@v1 |
Collaborator
There was a problem hiding this comment.
Let's not use a third-party action when gh release create exists. gh is pre-installed in gha runners
.github/workflows/linux.yml
Outdated
| - name: Checkout master on tag push | ||
| if: github.ref_type == 'tag' | ||
| # Checkout only if the tag was pushed to master | ||
| run: '[ "$(git rev-parse HEAD)" = "$(git rev-parse origin/master)" ] && git checkout master || echo False' |
.github/workflows/linux.yml
Outdated
Comment on lines
63
to
64
| # Setup compilation mode and install project dependencies | ||
| # (continue-on-error + timeout is a temporary solution until sentry-native is fixed; shouldn't affect the building step) |
Collaborator
There was a problem hiding this comment.
Isn't this comment outdated now? You fixed the hanging issue, right?
.github/workflows/linux.yml
Outdated
Comment on lines
79
to
81
| cp packaged/lib/libSTServer.so ${{ env.STR_BUILD_DIR }}/ || true | ||
| cp packaged/bin/crashpad_handler ${{ env.STR_BUILD_DIR }}/ || true | ||
| cp packaged/bin/SkyrimTogetherServer ${{ env.STR_BUILD_DIR }}/ || true |
Collaborator
There was a problem hiding this comment.
|| true? I think a job should fail if the file wasn't found during this step
.github/workflows/linux.yml
Outdated
Comment on lines
90
to
93
| path: | | ||
| ${{ env.STR_BUILD_DIR }}/libSTServer.so | ||
| ${{ env.STR_BUILD_DIR }}/crashpad_handler | ||
| ${{ env.STR_BUILD_DIR }}/SkyrimTogetherServer |
Collaborator
There was a problem hiding this comment.
Suggested change
| path: | | |
| ${{ env.STR_BUILD_DIR }}/libSTServer.so | |
| ${{ env.STR_BUILD_DIR }}/crashpad_handler | |
| ${{ env.STR_BUILD_DIR }}/SkyrimTogetherServer | |
| path: ${{ env.STR_BUILD_DIR }} |
Contributor
Author
|
Thanks for the review. Fixes applied:
GHA test run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
linux.ymlupload-build-for-next-jobwindows.ymlplayble-buildwindows-playable-build.yml→playable-build.ymlpreparejob for version extraction and conditionsDisable cron startup in forkslinux.ymlrelease-uploadjob on tag pushesNow
--- config: layout: dagre --- flowchart LR Prepare["Prepare job<br>(get version)"] --> CheckFork["Fork + schedule?"] CheckFork -- Yes --> Skip["Skip build"] CheckFork -- No --> Build["Build jobs<br>(Windows + Linux)"] ReleaseCheck["Is tag push?"] -- Yes --> Release["Create GitHub Release"] ReleaseCheck -- No --> n1["Just upload artifact"] Build --> ReleaseCheck n2["Start"] --> Prepare CheckFork@{ shape: rounded} ReleaseCheck@{ shape: terminal} n1@{ shape: rect} n2@{ shape: start} Prepare:::ProcessNode CheckFork:::DecisionNode Skip:::SkipNode Build:::WorkflowNode ReleaseCheck:::DecisionNode Release:::ProcessNode n1:::ProcessNode classDef StartNode stroke-width:2px,stroke:#4CAF50,fill:#E8F5E9,color:#2E7D32 classDef EndNode stroke-width:2px,stroke:#F44336,fill:#FFEBEE,color:#C62828 classDef DecisionNode stroke-width:2px,stroke:#FF9800,fill:#FFF3E0,color:#E65100 classDef ProcessNode stroke-width:2px,stroke:#2196F3,fill:#E3F2FD,color:#1565C0 classDef WorkflowNode stroke-width:2px,stroke:#9C27B0,fill:#F3E5F5,color:#6A1B9A classDef ArtifactNode stroke-width:2px,stroke:#00BCD4,fill:#E0F7FA,color:#00838F classDef SkipNode stroke-width:2px,stroke:#9E9E9E,fill:#FAFAFA,color:#424242Pre-merge
Test tag v9.9.9, New test tag v9.9.8windows-playable-build.ymltoplayable-build.ymlREADMEbadge linkGHA test run