Fix multiple starts of quests when in-party #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Raise logging level and fix logs of quest progression. Previously, multi-execution of quest stage entry was suppressed. But multi quest starts weren't. This is a problem when a quest start has side effects that advance quest stage; as the party members started their quests, the stage-rewind would reflect back to the leader, allowing quest stage side effects to happen again. Also added fix to debugger to force setStage. This is needed so leader can set the stage to the stage they are at, and not have it suppressed so it is sent to party. Regularized quest logging so you can import into a spreadsheet, break fields on colon and comma (:,)
rfortier
force-pushed
the
fix/no-duplicate-quest-start
branch
from
081ce9a to
bcc5ae9
Compare
Contributor
Author
|
Closing, this is about to be replaced with a far more complete PR. |
Contributor
Author
|
Reopening. This is the most recent version of quest stage multiple-trigger suppression (such as for The Way Of The Voice) that predates the full deduplication logic that follows it (but I was optimistic about how close to completion it was). This one is safe to merge while still polishing its successor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An update to PR #805 that fixes some additional cases.
Raise logging level and fix logs of quest progression to enable tracking this down.
Previously, multi-execution of quest stage entry was suppressed. But multi quest starts weren't. This is a problem when a quest start has side effects that advance quest stage; as the party members started their quests, the stage-rewind would reflect back to the leader, allowing quest stage side effects to happen again.
Also added fix to debugger to force setStage. This is needed so leader can set the stage to the stage they are at, and not have it suppressed so it is sent to party.
Regularized quest logging so you can import into a spreadsheet, break fields on colon and comma (:,)