Add JAWSM #87
Closed
Add JAWSM #87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
You can't use CI for testing, it doesn't run any tests. |
Author
|
@linusg yeah, I know, by troubleshooting I meant any comments from @CanadaHonk or someone else that knows more about the harness. I managed to make it work locally, so I think it's good to go. |
linusg
requested changes
Dec 16, 2024
Author
|
Thanks for the review @linusg, I fixed all the spots I found to be different than the example. |
Author
|
Also, linking a corresponding PR in eshost: test262-fyi/eshost#22 |
Member
|
Needs to be reworked for v2 (see #98), please open a new PR if still wanted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn't work yet, but I wanted to open a PR for troubleshooting