safe/fast mode: fix "main" fiber renaming. #474
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satbek
force-pushed
the
fix_fiber_name
branch
6 times, most recently
from
2050726 to
4f4c5b7
Compare
Tarantool allocates net_msg_max fibers to handle iproto requests. crud renames theese fibers to "_crud.call_on_storage/fast" and kills them by name on safe mode enabling. But after renaming fiber will process other non crud requests with the new name. And on safe mode enable crud can kill non releted fiber (for example config apply fiber). This will cause unpredictable errors. This commit fixes it by renaming fiber back to original name.
Satbek
force-pushed
the
fix_fiber_name
branch
from
4f4c5b7 to
d0014d0
Compare
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tarantool allocates net_msg_max fibers to handle iproto requests.
crud renames theese fibers to "_crud.call_on_storage/fast" and kills them by name on safe mode enabling.
But after renaming fiber will process other non crud requests with the new name. And on safe mode enable crud can kill non releted fiber (for example config apply fiber).
This will cause unpredictable errors.
This commit fixes it by renaming fiber back to original name.
What has been done? Why? What problem is being solved?
I didn't forget about
Closes #???