Skip to content

fix(adapter-node): validate ORIGIN env var at startup (#14978) #15045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
KiraPC wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(adapter-node): validate ORIGIN env var at startup (#14978) #15045

KiraPC wants to merge 2 commits into from
+92 −3

Conversation

@KiraPC
Copy link

@KiraPC KiraPC commented Dec 9, 2025 •
edited by elliott-with-the-longest-name-on-github
Loading

  • Add parse_origin() utility to validate and normalize origin URLs
  • Server now fails fast with clear error for invalid ORIGIN
  • Automatically normalize default ports and strip path/query/hash
  • Add tests for origin validation

Closes #14978

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

Edits

  • Please ensure that 'Allow edits from maintainers' is checked. PRs without this option may be closed.

fix(adapter-node): validate ORIGIN env var at startup (sveltejs#14978)
c754c30 
- Add parse_origin() utility to validate and normalize origin URLs
- Server now fails fast with clear error for invalid ORIGIN
- Automatically normalize default ports and strip path/query/hash
- Add tests for origin validation
@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c2b900f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sveltejs/adapter-node Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@KiraPC
Copy link
Author

KiraPC commented Dec 9, 2025

⚠️ No Changeset found

Latest commit: c754c30

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets
Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Added the changeset

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[adapter-node] - Use wrong ORIGIN value cause 400 Bad Request

1 participant

@KiraPC