Improvements #2
Open
Improvements #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before now the packages were split into SugarExt and SugarGestures, the existing build didn't consider this and put everything into one, which breaks the API as we'll have to track and change those uses. This changes that and maintains the existing API convention so we don't have to worry about changing existing use. I've also added some of the other files that aren't dependent on any x11 related library as I'd like to test this. I removed sugar-file-attributes entirely because that's something we never want to do, journal objects exist for a reason and I'd like to keep the current model without changing it. This has been replaced by sugar-fatattr which was used earlier and I decided that we should keep it based on its use and it doesn't break anything. Signed-off-by: Chihurumnaya Ibiam <[email protected]>
The API version change is necessary so as not to confuse this with the existing libraries. I've also ported sugar-clipboard to Gtk4, and added it here because Sugar still depends on it, and this is for my tests. I've also added install_gir and install_typelib as this made the install easier and installed the necessary files to the needed location, so I wouldn't have to be bothered about them. These files were generated but not installed in the right directory before now, and this makes sure they are so Python can see them on import. Signed-off-by: Chihurumnaya Ibiam <[email protected]>
Signed-off-by: Chihurumnaya Ibiam <[email protected]>
chimosky
force-pushed
the
improvements
branch
from
2089205 to
f60a0e6
Compare
Signed-off-by: Chihurumnaya Ibiam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some changes and structured this in a way that's helpful for us moving forward.
@MostlyKIGuess kindly review.