fix: add globPatterns to PWA config to cache SVG and PNG assets for offline use #465
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes PWA offline caching for SVG and PNG assets by adding globPatterns to the Vite PWA workbox configuration.
Changes
globPatterns: ['**/*.{js,css,html,ico,png,svg}']to workbox configuration inapp/tools/vite.config.tsProblem
Asset files generated during build with hashed filenames (e.g.,
run-123f2282.svg,logo-3080f493.png) were not being cached by the service worker, causing them to fail loading in offline mode.Solution
The globPatterns configuration ensures the service worker precaches all files matching the specified patterns, including SVG and PNG files regardless of their hash values.
Testing
Closes #321