Skip to content

Include missing components in the HTML output #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bact merged 13 commits into from
Nov 16, 2025
Merged

Include missing components in the HTML output #323

bact merged 13 commits into from
Nov 16, 2025

Conversation

@bact
Copy link
Collaborator

@bact bact commented Nov 12, 2025 •
edited
Loading

As a follow up of SPDX Online Tools update, update the conformance checker HTML output, to reduce the need of post-processing:

bact added 7 commits November 2, 2025 08:20
@bact
Add CSS class to HTML output
5dc845e 
Make it easier for consumers to define style of the HTML output

Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Fix lint line too long
3b66e01 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Move reporting functions to report.py
1184669 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Merge branch 'spdx:main' into add-html-class
b48b22d
@bact
Move min components to constant
5895c96 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Merge branch 'add-html-class' of https://github.com/bact/ntia-conform…
0409b67 
…ance-checker into add-html-class
@bact
Update HTML test
042945e 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact added this to the 4.1 milestone Nov 12, 2025
@bact bact added the enhancement New feature or request label Nov 12, 2025
@bact bact marked this pull request as draft November 12, 2025 00:34
bact added 4 commits November 12, 2025 02:00
@bact
Fix lint
cb4967a 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Fix black formatting
606e51a 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Remove unnecessary overloaded methods
ecc02ca 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
Add components without required info to HTML output
d7b817b 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
jspeed-meyers
jspeed-meyers reviewed Nov 12, 2025
View reviewed changes
jspeed-meyers
jspeed-meyers reviewed Nov 12, 2025
View reviewed changes
jspeed-meyers
jspeed-meyers approved these changes Nov 12, 2025
View reviewed changes
Copy link
Collaborator

@jspeed-meyers jspeed-meyers left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Left two minor nits. Nice job adding a clear and succinct test of this change.

bact added 2 commits November 15, 2025 23:23
@bact
Fix grammar
bc0c50b 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact
infos -> info
4da17ca 
Signed-off-by: Arthit Suriyawongkul <[email protected]>
@bact bact marked this pull request as ready for review November 16, 2025 00:53
@bact
Copy link
Collaborator Author

bact commented Nov 16, 2025

Updated the variable names as suggested.

@bact bact merged commit 0f33ec1 into spdx:main Nov 16, 2025
24 checks passed
@bact bact deleted the add-html-class branch November 16, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jspeed-meyers jspeed-meyers jspeed-meyers approved these changes

Assignees

@bact bact

Labels

enhancement New feature or request

Projects

None yet

Milestone

4.1

Development

Successfully merging this pull request may close these issues.

Add missing component info in HTML output

2 participants

@bact @jspeed-meyers