Skip to content

Conversation

@IraBoh
Copy link
Collaborator

@IraBoh IraBoh commented Nov 19, 2024

Context and Justification 🌍

Modifications πŸ”§

Contribution Checklist πŸ“‹

  • Have you used this PR template?   +2 pts
  • Is this PR focused on a single, clearly defined change?   +5 pts
  • Have you linked the issue(s) this PR resolves?   +5 pts
  • Are your changes well-documented and easy to follow?   +5 pts
  • Have you introduced a new feature?   -4 pts
    • Have you updated/added relevant documentation for it?   +4 pts
    • Have you included tests to ensure it works as expected?   +5 pts
  • Did you alter any core behavior of data-river?   -5 pts
    • Have you tested the changes thoroughly, ensuring no regressions?   +10 pts

@IraBoh
Copy link
Collaborator Author

IraBoh commented Nov 19, 2024

See the Test-Documentation
(#121 (comment))


const buttonVariants = cva(
"inline-flex items-center justify-center whitespace-nowrap rounded-md text-sm font-medium transition-colors focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring disabled:pointer-events-none disabled:opacity-50",
"inline-flex items-center justify-center rounded-md text-sm font-medium transition-colors focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:opacity-50 disabled:pointer-events-none ring-offset-background",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will those changes impact other places where component is used?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants