Skip to content

Conversation

@latisaron
Copy link
Contributor

@latisaron latisaron commented Jul 10, 2025

…g around integration, logging level

As per ioquatix/ioquatix#39 I have opened up a pull request containing some MD agent-ready context.

Types of Changes

  • New feature.

Contribution

@latisaron latisaron marked this pull request as draft July 10, 2025 21:18
@ioquatix
Copy link
Member

I think we can probably remove the implementation details and focus on the integration / usage.

I would then suggest adding a brief section on how to actually approach the problem of improving coverage - e.g. describe the process of running tests with coverage, identifying missing coverage, and then writing a test to cover it.

@latisaron
Copy link
Contributor Author

Got it, will submit another draft either today or tomorrow.

…ces, usage, security consideratins and a step-by-step list of how to improve coverage
@ioquatix
Copy link
Member

For now, I think up until line 112 is good, we should not go into too much detail about the actual test frameworks IMHO.

@latisaron
Copy link
Contributor Author

I also added a step by step explanation of how to iteratively improve a codebase s test coverage at the end.

I can remove anything related to testing frameworks and leave the main ideas behind;

If you're not okay with that I'll just leave it up to line 112

@ioquatix
Copy link
Member

I think up to line 112 is good enough for now.

The reason why is I want to ensure these files remain focused, so that agents consult them + they should consult other test framework specific files on how to write good tests. If it turns out that this doesn't work well, we can revisit it. I'd rather start a little simpler and increase in complexity (entropy) as required.

Is that reasonable?

…agents to consult the frameworks specific files'
@latisaron
Copy link
Contributor Author

latisaron commented Jul 16, 2025

Got it, yeah makes perfect sense, I'll update the PR, thanks for the explanation!

Let me know if you want me to rebase this into a single commit or anything of the sort.

Copy link
Member

@ioquatix ioquatix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM.

@latisaron latisaron marked this pull request as ready for review July 17, 2025 09:10
@samuel-williams-shopify samuel-williams-shopify merged commit 7a2e500 into socketry:main Jul 21, 2025
10 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants