Add v1-latest as version option #109
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 24, 2025
pwright
requested changes
Nov 25, 2025
| -H "X-GitHub-Api-Version: 2022-11-28" \ | ||
| https://api.github.com/repos/skupperproject/skupper/releases \ | ||
| | jq -r 'map(select( (.prerelease or .draft) | not )) | map(select(.name | startswith ("1."))) | map(select( .name | match("[0-9.]+") ) ) | sort_by (.name|split(".")|map(tonumber))[-1].name' \ | ||
| >| "${release_version_file}" |
Member
There was a problem hiding this comment.
| operator: will crash the installer for non bash users, eg folks on Debian/Ubuntu systems.
Suggested change
| >| "${release_version_file}" | |
| > "${release_version_file}" |
nluaces
reviewed
Dec 3, 2025
|
|
||
| Versions: | ||
| latest The latest release | ||
| v1-latest The latest release in the 1.x line |
Member
There was a problem hiding this comment.
I have the impression that if a user wants v1 they will specify a version (and that v1-latest is only useful for dev purposes).
Member
|
I vote for #110 solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one of two options for allowing to install the latest v1 CLI via install.sh.
The other one is #110.
On this option, a new 'v1-latest' version option is added.