Skip to content

Conversation

@michaelsproul
Copy link
Member

No description provided.

@michaelsproul
Copy link
Member Author

Hi @copilot, could you try implementing an iterator over ProgTree which wraps an iter::Iter instance and keeps track of the next ProgNodes to continue iterating from? The iterator should iterate all elements in the first right child, and then the right child of the first left child, right child of the second left child, and so on. The ProgTree structure is represented by this diagram below:

        root
         /\
        /  \
       /\   1: chunks[0 ..< 1]
      /  \
     /\   4: chunks[1 ..< 5]
    /  \
   /\  16: chunks[5 ..< 21]
  /  \
 0   64: chunks[21 ..< 85]

For more details you can also read EIP-7916: https://eips.ethereum.org/EIPS/eip-7916.

Copy link
Contributor

Copilot AI commented Nov 26, 2025

@michaelsproul I've opened a new pull request, #84, to work on those changes. Once the pull request is ready, I'll request review from you.

@michaelsproul michaelsproul marked this pull request as ready for review December 1, 2025 02:43
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 75.46012% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 73.02%. Comparing base (dbe9e15) to head (edd833b).

Files with missing lines Patch % Lines
src/progressive_list.rs 66.66% 20 Missing ⚠️
src/prog_tree.rs 83.00% 17 Missing ⚠️
src/context_deserialize.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #82      +/-   ##
==========================================
+ Coverage   70.38%   73.02%   +2.63%     
==========================================
  Files          22       24       +2     
  Lines        1263     1427     +164     
==========================================
+ Hits          889     1042     +153     
- Misses        374      385      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@michaelsproul
Copy link
Member Author

Hey @copilot, can you try adding ProgressiveList to the proptest suite of tests in src/tests/proptest/operations.rs? You'll need a new ProgressiveSpec data structure that doesn't have a length limit (no N), but you can reuse the same Op structure as we should support all of the same ops eventually (for now their implementations on ProgressiveList can be no-ops if not implemented). You'll want to write a new function apply_ops_progressive_list.

Copy link
Contributor

Copilot AI commented Dec 1, 2025

@michaelsproul I've opened a new pull request, #89, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan

* Add ProgressiveList to proptest suite

Co-authored-by: michaelsproul <[email protected]>

* Refactor progressive list tests to only include supported operations

Co-authored-by: michaelsproul <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: michaelsproul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants