fix(component-library): re-add small size to mt-text-field #913
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Haberkamp
force-pushed
the
re-add-small-size-to-text-field
branch
from
cbf9452 to
32e5a40
Compare
Haberkamp
force-pushed
the
re-add-small-size-to-text-field
branch
from
32e5a40 to
5bb4431
Compare
Haberkamp
force-pushed
the
re-add-small-size-to-text-field
branch
from
e546db2 to
feda456
Compare
Haberkamp
force-pushed
the
re-add-small-size-to-text-field
branch
from
dfec582 to
ae9e7b0
Compare
Haberkamp
force-pushed
the
re-add-small-size-to-text-field
branch
from
3267215 to
a46e426
Compare
Contributor
|
I'm closing this pr as it is resolved in #1033 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
I've re-added the small size for the input field.
Why?
In some cases need smaller input fields. They're already worked but we added a regression.
How?
I've updated the selectors to scope the block fields and not the base fields.
Testing?
I've added a new visual tests for the small input field. The existing ones make sure we do not
Anything Else?
This also adds the small size to other input fields as well.