feat: Add new tab with message binding to channel documentation and a…#1
Draft
feat: Add new tab with message binding to channel documentation and a…#1
Conversation
✅ Deploy Preview for rainbow-profiterole-502abf ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
sam0r040
commented
Jan 13, 2023
| [value]="defaultExample?.value" | ||
| (keyup)="recalculateLineCount('example', exampleTextArea.value)" | ||
| ></textarea> | ||
| <div [hidden]="isEmptyObject(operation.message.bindings.get(protocolName))" fxLayout="column" fxLayoutGap="5px"> |
Owner
Author
There was a problem hiding this comment.
I thought it might be a good idea to hide elements if they are not part of the spec (for headers and message binding). [hidden] is used instead of *ngif because ngif will not even render the components, which will result in issues with other code (ie reseting to default values)
sam0r040
commented
Jan 13, 2023
| [value]="headersExample?.value" | ||
| (keyup)="recalculateLineCount('headers', headersTextArea.value)" | ||
| ></textarea> | ||
| <app-json [json]="headersExample?.value"></app-json> |
Owner
Author
There was a problem hiding this comment.
I switched the editable example to the message view and changed it to readonly here.
sam0r040
commented
Jan 13, 2023
|
|
||
| ngOnInit(): void { | ||
| this.json = JSON.stringify(this.data, null, 2); | ||
| this.json = this.json === undefined ? JSON.stringify(this.data, null, 2) : this.json; |
Owner
Author
There was a problem hiding this comment.
I changed the component so that it can render object or json to make it more flexible for different use cases
…dd header and message binding example to example tab
…he backend can use the message binding to construct a message
… creates a specification without message binding
… to log statement when producing messages
Regression: Previously included mapped ui attributes chore: Improve [protocol: string]: any typings Co-authored-by: [email protected]
sam0r040
force-pushed
the
feature/add_message_binding_to_channel_documentation
branch
from
3ffd54e to
967a029
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…dd header and message binding example to example tab