Skip to content

Conversation

@phil-davis
Copy link
Contributor

Backport #723 to 4.5 branch.

Part of issue #722

@codecov
Copy link

codecov bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.65%. Comparing base (cb00630) to head (0ddd4bc).
⚠️ Report is 5 commits behind head on 4.5.

Additional details and impacted files
@@            Coverage Diff            @@
##                4.5     #740   +/-   ##
=========================================
  Coverage     98.65%   98.65%           
- Complexity     1932     1933    +1     
=========================================
  Files            71       71           
  Lines          5296     5298    +2     
=========================================
+ Hits           5225     5227    +2     
  Misses           71       71           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phil-davis
Copy link
Contributor Author

phil-davis commented Dec 2, 2025

ToDo:

  • sort out using $version correctly in the tests, so that we do not need to edit the literal version when it changes
  • sort out code that does not work with PHP 7.1 and 7.2
  • sort out which changes here should also be forward-ported to master

@phil-davis phil-davis merged commit d1f8aba into sabre-io:4.5 Dec 2, 2025
12 checks passed
@phil-davis phil-davis deleted the backport-723-4.5 branch December 2, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants