Skip to content

Conversation

@KristofferFM
Copy link
Contributor

The method Broker::parseEventForOrganizer is long and might not be that easy to read and understand. Near the end of the method, the variable $attendee which is used in major parts of the method as an iterator pointer, is suddenly re-used as an iterator pointer in another context. Even though this does not lead to any problems right now, it could be a problem in the future, i.e. when someone wants to extend the function. Therefore, I propose to rename the inner $attendee iterator variable.

@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.78%. Comparing base (61c968d) to head (0351e78).
⚠️ Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master     #721   +/-   ##
=========================================
  Coverage     98.78%   98.78%           
- Complexity     1875     1877    +2     
=========================================
  Files            71       71           
  Lines          5272     5274    +2     
=========================================
+ Hits           5208     5210    +2     
  Misses           64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@phil-davis phil-davis merged commit 46daffb into sabre-io:master Dec 2, 2025
8 of 9 checks passed
@phil-davis
Copy link
Contributor

Backport to 4.5 branch is PR #742

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants