Support for configuration files #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctz
force-pushed
the
jbp-config-file
branch
5 times, most recently
from
f89047b to
7b9728d
Compare
djc
reviewed
Dec 27, 2025
ctz
force-pushed
the
jbp-config-file
branch
3 times, most recently
from
60f117e to
603e8ad
Compare
djc
approved these changes
Dec 29, 2025
djc
approved these changes
Dec 29, 2025
Member
Author
|
Have applied those suggestions, but I still wasn't happy with an aspect of this. Specifically how |
- additional commands for printing the configuration file path, and current configuration text. - use of `xdg` crate to have sane behaviour on operating systems meeting XDG Base Directory specification. - simplify `fetch` subcommand interface - polyfill xdg crate on non-linux platforms
djc
approved these changes
Dec 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xdgcrate to have sane behaviour on operating systems meeting XDG Base Directory specification.fetchsubcommand interface