Add "reads after ungetc with multibyte characters in the buffer" spec… #1279
+8
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrykonchin
reviewed
Aug 4, 2025
library/stringio/readpartial_spec.rb
Outdated
| @@ -1,3 +1,4 @@ | |||
| # encoding: binary | |||
Member
There was a problem hiding this comment.
Probably we can avoid this just by converting string literals to binary encoding explicitly:
@string.readpartial(3).should == "\xE2\x88\x82".b
@string.readpartial(3).should == "\xCF\x86/".bDoes it look better?
Member
There was a problem hiding this comment.
Yes that seems a bit better, I'll try it.
There used to be an issue that the parser gem couldn't parse such things but it probably matters much less now that Prism can be used instead.
… to StringIO#readpartial This one was missing in ruby#1278, I got it to work with the `encoding: binary` directive. The StringIO code was fine, the spec was just incomplete.
eregon
force-pushed
the
stringio_readpartial
branch
from
632378a to
261038f
Compare
eregon
approved these changes
Jan 4, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… to StringIO#readpartial
This one was missing in #1278, I got it to work with the
encoding: binarydirective. The StringIO code was fine, the spec was just incomplete.