[ci] Do not clone all the history of the repo #20814
Open
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 19 files 19 suites 3d 6h 29m 49s ⏱️ Results for commit 29dbc50. ♻️ This comment has been updated with latest results. |
dpiparo
added
in:CI
and removed
clean build
pcanal
reviewed
Jan 7, 2026
| else: | ||
| returncode = subprocess_with_log(f""" | ||
| git clone --branch {branch} --single-branch {repository} "{targetdir}" | ||
| git clone --depth 1 --branch {branch} --single-branch {repository} "{targetdir}" |
Member
There was a problem hiding this comment.
I ponder if 1 is the right number. If I remember correctly, we need some history to find the merging point between PR and the master in some circumstances.
Collaborator
There was a problem hiding this comment.
maybe as a two-step process? If the search fails, then we clone fully?
Member
Author
There was a problem hiding this comment.
it is indeed what one can see in the incremental builds. I wonder whether it's an optimisation worth the complication in the code...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should shave off 1-2 minutes from every build.