[df] First integration of RHist filling
#20664
Conversation
Test Results 22 files 22 suites 3d 22h 57m 1s ⏱️ Results for commit 2161b70. ♻️ This comment has been updated with latest results. |
hahnjo
left a comment
hahnjo
left a comment
There was a problem hiding this comment.
Things to discuss during review (after the break)
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you! The PR is already in an advanced state, I have left some minor comments
As the classes are experimental, using the method will print a warning to inform the user.
vepadulano
left a comment
vepadulano
left a comment
There was a problem hiding this comment.
Thank you! Feel free to merge once the CI is green.
I believe as a followup we should introduce at some point one (or more) tutorials, specifically with examples that compare using Histo[1,2,3,N]D and Hist to help users in the future transition (or not, depending on what they will want to do).
This needs one indirection to construct the std::tuple and separate the weight argument.
Yes, tutorials are on my list. We probably want tutorials for:
|
As the classes are experimental, using the method will print a warning to inform the user.
Note that this is only a first version, there are a couple of advanced functionalities and better error handling that will come in future PRs.