-
Notifications
You must be signed in to change notification settings - Fork 113
Remove Cloudflare, Netlify, and Vercel templates #161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Cloudflare's official tool |
Yeah the create-cloudflare app totally relies upon this template. I have put up a short-term fix here cloudflare/workers-sdk#10790 but I hoper we can have a better long term solution. |
|
similarly create-react-router supports full github url so |
While there is no release containing that change yet, use: |
|
What's the rational and the benefits behind removing vendor templates? Especially the cloudflare one. Also, these vendors are still expecting these templates to be there so all their react router (formerly remix) documentation pages are misleading. Shouldn't their pages be updated before such templates be removed? Regardless, what will be the recommended approach, beyond using and outdated version of this repo, to create a cloudflare-compatible react-router app? Will we have to wait for cloudflare to release their own template but use |
|
I've added the Cloudflare template back in #162 Sorry, I should have done a more thorough job looking into exactly what Cloudflare's CLI was doing, I was not anticipating it to be a wrapper around our own. Either way, I should have coordinated better.
The rational is vendors like Vercel and Netlify already have their own templates and guides (Cloudflare does too, but as pointed out it relies on our template).
I'm working with Cloudflare on that. If they are maintaining their own docs and have a CLI already that they encourage their customers to use, our preference is that they would also maintain the template as well. We'll work together though on a solution, neither of us wants to add barriers to deploying a React Router app on Cloudflare. However, in the meantime I merged #162, so the Cloudflare CLI should be working again |
|
understood, thanks |
For these vendors we are directing users towards their official guides