Skip to content

Conversation

@brookslybrand
Copy link
Contributor

For these vendors we are directing users towards their official guides

@arianrhodsandlot
Copy link

Cloudflare's official tool create-cloudflare mentioned in their official guide is also depending on the deleted template in this pull request, see https://github.com/cloudflare/workers-sdk/blob/8eb7197572d46703850ca0425e4b85ded0f07beb/packages/create-cloudflare/templates/react-router/c3.ts#L13 . The updates here are breaking the official create-cloudflare.

@petebacondarwin
Copy link

Cloudflare's official tool create-cloudflare mentioned in their official guide is also depending on the deleted template in this pull request, see https://github.com/cloudflare/workers-sdk/blob/8eb7197572d46703850ca0425e4b85ded0f07beb/packages/create-cloudflare/templates/react-router/c3.ts#L13 . The updates here are breaking the official create-cloudflare.

Yeah the create-cloudflare app totally relies upon this template.

I have put up a short-term fix here cloudflare/workers-sdk#10790 but I hoper we can have a better long term solution.

@edgji
Copy link

edgji commented Sep 27, 2025

similarly create-react-router supports full github url so create-react-router@latest --template https://github.com/remix-run/react-router-templates/tree/29ac272b9532fe26463a2d2693fc73ff3c1e884b/cloudflare works until create-cloudflare gets updated

@tschmidt01
Copy link

Cloudflare's official tool create-cloudflare mentioned in their official guide is also depending on the deleted template in this pull request, see https://github.com/cloudflare/workers-sdk/blob/8eb7197572d46703850ca0425e4b85ded0f07beb/packages/create-cloudflare/templates/react-router/c3.ts#L13 . The updates here are breaking the official create-cloudflare.

Yeah the create-cloudflare app totally relies upon this template.

I have put up a short-term fix here cloudflare/workers-sdk#10790 but I hoper we can have a better long term solution.

While there is no release containing that change yet, use:

pnpm dlx https://pkg.pr.new/create-cloudflare@10790 my-react-router-app --framework=react-router

@charbeltabet
Copy link

charbeltabet commented Sep 29, 2025

What's the rational and the benefits behind removing vendor templates? Especially the cloudflare one.

Also, these vendors are still expecting these templates to be there so all their react router (formerly remix) documentation pages are misleading. Shouldn't their pages be updated before such templates be removed?

Regardless, what will be the recommended approach, beyond using and outdated version of this repo, to create a cloudflare-compatible react-router app?

Will we have to wait for cloudflare to release their own template but use create-react-router@latest --template https://github.com/remix-run/react-router-templates/tree/29ac272b9532fe26463a2d2693fc73ff3c1e884b/cloudflare in the meantime?

@brookslybrand
Copy link
Contributor Author

brookslybrand commented Sep 29, 2025

I've added the Cloudflare template back in #162

Sorry, I should have done a more thorough job looking into exactly what Cloudflare's CLI was doing, I was not anticipating it to be a wrapper around our own. Either way, I should have coordinated better.

What's the rational and the benefits behind removing vendor templates?

The rational is vendors like Vercel and Netlify already have their own templates and guides (Cloudflare does too, but as pointed out it relies on our template).

Regardless, what will be the recommended approach, beyond using and outdated version of this repo, to create a cloudflare-compatible react-router app?

I'm working with Cloudflare on that. If they are maintaining their own docs and have a CLI already that they encourage their customers to use, our preference is that they would also maintain the template as well. We'll work together though on a solution, neither of us wants to add barriers to deploying a React Router app on Cloudflare. However, in the meantime I merged #162, so the Cloudflare CLI should be working again

@charbeltabet
Copy link

understood, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants