chore: upgrade codemirror-graphql from 1.0.2 to 2.2.4 #604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a vulnerability in 'ws', which was brought in by codemirror-graphql, reported in mdx-renderer, so upgrade that library. Following the upgrade, it no longer has a dependency on ws, which is nice
Author
|
I'm not sure why I'm getting the package-lock failure, I am using node 22.21 to create it? |
domharrington
approved these changes
Jan 9, 2026
Member
domharrington
left a comment
domharrington
left a comment
There was a problem hiding this comment.
Hell yeah! The best dependency is no dependency.
Author
|
The CI is not running and I don't know why not |
Author
|
Oh actually it seems to have failed but is just spinning? weird |
Author
|
I'm going to leave this open until Jon can review it, this seems like his project |
Member
|
Poured through our |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧰 Changes
We had a vulnerability in 'ws', which was brought in by codemirror-graphql,
reported in mdx-renderer, so upgrade that library. Following the upgrade,
it no longer has a dependency on ws, which is nice
cf https://github.com/readmeio/mdx-renderer/pull/283
🧬 QA & Testing
All I did was run the tests, verify that they passed, and that they included a graphql test