feat: new app icon for liquid glass #829
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds a new liquid glass app icon across the project, updates CI to a newer macOS runner, and replaces the old PNG-based logo with a Svelte SVG component.
- Registers
AppIcon.iconin the Xcode project and adds its configuration file - Introduces
LogoIcon.svelteand updatesApp.svelteto use it instead of a PNG - Updates the GitHub Actions workflow to target a newer macOS runner and Xcode version
Reviewed Changes
Copilot reviewed 5 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| xcode/Userscripts.xcodeproj/project.pbxproj | Added build-file, file-reference, and group entries for AppIcon |
| xcode/App-Shared/AppIcon.icon/icon.json | New JSON config describing the liquid glass icon appearance |
| src/shared/Components/LogoIcon.svelte | New Svelte component rendering the SVG-based app icon |
| src/app/App.svelte | Replaced <img> with <LogoIcon /> and adjusted related styles |
| .github/workflows/deployment.yaml | Updated runs-on label and xcode-select path in CI workflow |
Comments suppressed due to low confidence (2)
.github/workflows/deployment.yaml:12
- Verify that GitHub Actions supports the
macos-15runner label; if not, switch tomacos-latestor another valid image to avoid pipeline failures.
runs-on: macos-15 # https://github.com/actions/runner-images
.github/workflows/deployment.yaml:41
- The path
/Applications/Xcode_26.0.appmay not exist on the runner; update this to the actual installed Xcode version (e.g., Xcode_16.2) or make it configurable.
run: sudo xcode-select -s "/Applications/Xcode_26.0.app" # https://github.com/actions/runner-images/blob/main/images/macos/macos-14-arm64-Readme.md#xcode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #818
New App icon with dark mode, mono mode created with the latest guidelines and tools.
https://developer.apple.com/icon-composer/
https://www.youtube.com/watch?v=4usD1hP1nYY
https://developer.apple.com/documentation/Xcode/creating-your-app-icon-using-icon-composer
ios.mp4
macos.mp4